Titanium Studio
  1. Titanium Studio
  2. TISTUD-2920

TiApp Editor with invalid sdk value opens in dirty state with no notification

    Details

    • Story Points:
      5

      Description

      Steps:
      1. Open a tiapp.xml with invalid sdk value (open tiapp.xml in text editor and change version to an invalid one. Open in tiapp.xml editor)

      Expected results:
      1. The editor should have error/warning about the invalid sdk version, or update to the latest sdk value and open a message dialog stating the sdk version was changed to a valid version

      Actual results:
      There are warnings displayed for a split second, then the warnings disappears and the editor is in dirty state

        Issue Links

          Activity

          Hide
          Shalom Gibly added a comment -

          Fixed and pushed to all branches.

          Show
          Shalom Gibly added a comment - Fixed and pushed to all branches.
          Hide
          Clayton Headley (Inactive) added a comment -

          Tested in Titanium Studio, build: 3.0.1.201212051858, after opening the tiapp.xml the SDK changes to the most recent version and the file becomes marked as dirty. No warning is given to the user that this change has occurred other then marking the file has been changed. This does not match either of the expected results from above. Reopening ticket.

          Show
          Clayton Headley (Inactive) added a comment - Tested in Titanium Studio, build: 3.0.1.201212051858, after opening the tiapp.xml the SDK changes to the most recent version and the file becomes marked as dirty. No warning is given to the user that this change has occurred other then marking the file has been changed. This does not match either of the expected results from above. Reopening ticket.
          Hide
          Clayton Headley (Inactive) added a comment -

          Tested in Titanium Studio, build: 3.1.0.201212051932 and the fix works. The SDK is changed and a warning is marked for the user.

          Show
          Clayton Headley (Inactive) added a comment - Tested in Titanium Studio, build: 3.1.0.201212051932 and the fix works. The SDK is changed and a warning is marked for the user.
          Hide
          Shalom Gibly added a comment -

          Looks like this issue still occurs on 3.0.1, but not on 3.1.0.

          Pushed the related fix for TISTUD-2905 to the release branch. So this should resolve this one for the 3.0.1.

          Show
          Shalom Gibly added a comment - Looks like this issue still occurs on 3.0.1, but not on 3.1.0. Pushed the related fix for TISTUD-2905 to the release branch. So this should resolve this one for the 3.0.1.
          Hide
          Dustin Hyde added a comment - - edited

          Closing as Fixed.

          Verified On:

          Titanium Studio: jenkins-3.0.0.201212071410
          OS: Mountain Lion 10.8.2, Lion 10.7.5

          Test Steps:

          1. Edit tiapp.xml to invalid sdk in xml tags and save.
          2. Open TiApp Editor Overview for same tiapp.xml file.

          Expected Result:

          Warning appears, tiapp.xml becomes dirty, and a valid Titanium SDK is now selected.

          Show
          Dustin Hyde added a comment - - edited Closing as Fixed. Verified On: Titanium Studio: jenkins-3.0.0.201212071410 OS: Mountain Lion 10.8.2, Lion 10.7.5 Test Steps: 1. Edit tiapp.xml to invalid sdk in xml tags and save. 2. Open TiApp Editor Overview for same tiapp.xml file. Expected Result: Warning appears, tiapp.xml becomes dirty, and a valid Titanium SDK is now selected.

            People

            • Assignee:
              Shalom Gibly
              Reporter:
              Nam Le
            • Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: