Android: Appversion never taken from tiapp.xml

Details

  • Story Points:
    3

Description

I found this bug while I created new release for Android Market.

appversion is never changed from tiapp.xml file (version tag). I send you patch to correct this, to apply on 1.0.0/android/android.py

Issue Links

relates to

Epic - A big user story that needs to be broken down. TIMOB-9028 CLI: "build" command for Android apps

  • Critical - Blocks development and/or testing work, production could not run.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Story - An user story TIMOB-14973 Android Build: Validate command line arguments and tiapp.xml settings

  • High - Crashes, loss of data, severe memory leak.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.
mentioned in

Wiki Page Loading...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Metal3d added a comment -
{html}<div><p>There is a trouble with this patch... in fact with "android"
manifest if you need to specify a floating value for version. It
could be cool to correct this quickly, everybody wich needs to
upload a new revision on android market is blocked because the
appversion need to greater than previous</p></div>{html}
Show
Metal3d added a comment - {html}<div><p>There is a trouble with this patch... in fact with "android" manifest if you need to specify a floating value for version. It could be cool to correct this quickly, everybody wich needs to upload a new revision on android market is blocked because the appversion need to greater than previous</p></div>{html}
Hide
Permalink
Stephen Tramer added a comment -
{html}<div><p>Assigning to Don for triage... but bounce it back to iOS once
you've handled it so we can check the report as well.</p></div>{html}
Show
Stephen Tramer added a comment - {html}<div><p>Assigning to Don for triage... but bounce it back to iOS once you've handled it so we can check the report as well.</p></div>{html}
Hide
Permalink
Don Thorp added a comment -
{html}<div><p>There is a reason the version tag isn't used, because it's not
sufficient for Android. You need to specify them in the android
section of the tiapp.xml in the application element. Android
requires an integer version that is incremented for each release
AND a string version that can be everything. I will leave it in TBS
so we can discuss it, but until we get project/platform specific
settings it has to be done through the android manifest.</p></div>{html}
Show
Don Thorp added a comment - {html}<div><p>There is a reason the version tag isn't used, because it's not sufficient for Android. You need to specify them in the android section of the tiapp.xml in the application element. Android requires an integer version that is incremented for each release AND a string version that can be everything. I will leave it in TBS so we can discuss it, but until we get project/platform specific settings it has to be done through the android manifest.</p></div>{html}
Hide
Permalink
Jon Alter added a comment -
{html}<div><h3>Associated Helpdesk Ticket</h3>
<p><a href=
"http://developer.appcelerator.com/helpdesk/view/76595">http://developer.appcelerator.com/helpdesk/view/76595</a></p></div>{html}
Show
Jon Alter added a comment - {html}<div><h3>Associated Helpdesk Ticket</h3> <p><a href= "http://developer.appcelerator.com/helpdesk/view/76595"> http://developer.appcelerator.com/helpdesk/view/76595 </a></p></div>{html}
Hide
Permalink
Jon Alter added a comment -

Associated Helpdesk Ticket

http://appc.me/c/APP-835962

Show
Jon Alter added a comment - Associated Helpdesk Ticket http://appc.me/c/APP-835962
Hide
Permalink
Josh Roesslein added a comment - - edited

We still don't generate a new versionCode for the AndroidManifest.xml when the
"version" in tiapp.xml is updated. As mentioned in previous comment this is mostly due to Android
requiring this to be an integer.

http://developer.android.com/guide/topics/manifest/manifest-element.html#vcode

Show
Josh Roesslein added a comment - - edited We still don't generate a new versionCode for the AndroidManifest.xml when the "version" in tiapp.xml is updated. As mentioned in previous comment this is mostly due to Android requiring this to be an integer. http://developer.android.com/guide/topics/manifest/manifest-element.html#vcode
Hide
Permalink
Chris Barber added a comment -

In Titanium SDK 3.2, we will populate the "android:versionName" with the <version> from the tiapp.xml. The "android:versionCode" will default to "1". You can override both of these values via the tiapp.xml:

<android>
    <manifest android:versionName="whatever" android:versionCode="1"></manifest>
</android>
Show
Chris Barber added a comment - In Titanium SDK 3.2, we will populate the "android:versionName" with the <version> from the tiapp.xml. The "android:versionCode" will default to "1". You can override both of these values via the tiapp.xml: <android> <manifest android:versionName="whatever" android:versionCode="1"></manifest> </android>
Hide
Permalink
Allen Yeung added a comment -

PR: https://github.com/appcelerator/titanium_mobile/pull/4781

Show
Allen Yeung added a comment - PR: https://github.com/appcelerator/titanium_mobile/pull/4781
Hide
Permalink
Samuel Dowse added a comment -

Verified fixed on:
Mac OSX 10.9 Mavericks
Titanium Studio, build: 3.2.0.201311122225
Titanium SDK, build: 3.2.0.v20131112144044
CLI: 3.2.0
Alloy: 1.3.0

Android version can be specified in the tiapp.xml
Closing.

Show
Samuel Dowse added a comment - Verified fixed on: Mac OSX 10.9 Mavericks Titanium Studio, build: 3.2.0.201311122225 Titanium SDK, build: 3.2.0.v20131112144044 CLI: 3.2.0 Alloy: 1.3.0 Android version can be specified in the tiapp.xml Closing.

People

  • Assignee:
    Chris Barber
    Reporter:
    Metal3d
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: