Titanium Mobile
  1. Titanium Mobile
  2. TIMOB-3331

Android: passwordMask does not disable autocomplete and dictionary

    Details

      Description

      {html}<div><p>In Android, a textField with passwordMask: true, still shows
      autocomplete and dictionary items.</p>
      <p>Step1: open KitchenSink<br>
      Step2: Controls > Text Field > The Rest<br>
      Step3: type something in text field to ensure that autocomplete
      shows up, if it does continue to step4<br>
      Step4: click 'Password Mask'<br>
      Step5: type a word in the text field<br>
      Step6: notice autocomplete showing up allowing you to see what is
      being typed in spite of the passwordMask<br>
      (See attached picture)</p>
      <h3>Tested On ###</h3>
      <p>TiSDK 1.6.0, Android 2.3.2, Nexus S</p>
      <h3>Associated Helpdesk Ticket</h3>
      <p><a href=
      "http://developer.appcelerator.com/helpdesk/view/76395">http://developer.appcelerator.com/helpdesk/view/76395</a></p></div>{html}

        Issue Links

          Activity

          Hide
          vetler (at gmail) added a comment -
          {html}<div><p>If it breaks, why is this not commented on the pull request? I
          would be more than happy to fix it.<br>
          <a href=
          "https://github.com/appcelerator/titanium_mobile/pull/81">https://github.com/appcelerator/titanium_mobile/pull/81</a></p>
          <p>It should trigger if password masking is enabled, and I don't
          see any obvious reasons not to switch to
          InputType.TYPE_TEXT_VARIATION_PASSWORD.</p></div>{html}
          Show
          vetler (at gmail) added a comment - {html}<div><p>If it breaks, why is this not commented on the pull request? I would be more than happy to fix it.<br> <a href= "https://github.com/appcelerator/titanium_mobile/pull/81"> https://github.com/appcelerator/titanium_mobile/pull/81 </a></p> <p>It should trigger if password masking is enabled, and I don't see any obvious reasons not to switch to InputType.TYPE_TEXT_VARIATION_PASSWORD.</p></div>{html}
          Hide
          Don Thorp added a comment -
          {html}<div><p>I'm testing across emulators and devices other than 2.3. If I
          could tell you what to fix, I'd already have fixed it. It looks
          likes like the problem is 2.3 dependent on device. No worries just
          trying to work through all the combinations where the value gets
          set and unset.</p></div>{html}
          Show
          Don Thorp added a comment - {html}<div><p>I'm testing across emulators and devices other than 2.3. If I could tell you what to fix, I'd already have fixed it. It looks likes like the problem is 2.3 dependent on device. No worries just trying to work through all the combinations where the value gets set and unset.</p></div>{html}
          Hide
          vetler (at gmail) added a comment -
          {html}<div><p>Interesting ... I couldn't reproduce the bug in the emulator,
          but showed up on my Samsung Galaxy S. Didn't try other Android
          versions in the emulator than the one I had set up though.<br>
          Is the bug reproducible in the Android emulator at all?</p></div>{html}
          Show
          vetler (at gmail) added a comment - {html}<div><p>Interesting ... I couldn't reproduce the bug in the emulator, but showed up on my Samsung Galaxy S. Didn't try other Android versions in the emulator than the one I had set up though.<br> Is the bug reproducible in the Android emulator at all?</p></div>{html}
          Hide
          Don Thorp added a comment -
          {html}<div><p>We tested on 2.2.2 and 2.3.1 with the patch and it seems to be
          ok due to the order of when the password mask is applied. Thanks
          @vetler for the patch. Sorry it took this long, but other
          variations I was testing with flags were having some issues. I'm
          not positive there won't be a side-effect if someone tries to
          switch a password field to another field, but that's not the normal
          use case.</p>
          <p><a href=
          "https://github.com/appcelerator/titanium_mobile/commit/bbe956c79e537faa51c191ef1af2a9892933a5a7">
          https://github.com/appcelerator/titanium_mobile/commit/bbe956c79e537faa51c191ef1af2a9892933a5a7</a></p></div>{html}
          Show
          Don Thorp added a comment - {html}<div><p>We tested on 2.2.2 and 2.3.1 with the patch and it seems to be ok due to the order of when the password mask is applied. Thanks @vetler for the patch. Sorry it took this long, but other variations I was testing with flags were having some issues. I'm not positive there won't be a side-effect if someone tries to switch a password field to another field, but that's not the normal use case.</p> <p><a href= "https://github.com/appcelerator/titanium_mobile/commit/bbe956c79e537faa51c191ef1af2a9892933a5a7"> https://github.com/appcelerator/titanium_mobile/commit/bbe956c79e537faa51c191ef1af2a9892933a5a7 </a></p></div>{html}
          Hide
          vetler (at gmail) added a comment -
          {html}<div><p>Great, happy to help! </p></div>{html}
          Show
          vetler (at gmail) added a comment - {html}<div><p>Great, happy to help! </p></div>{html}

            People

            • Assignee:
              Don Thorp
              Reporter:
              Jon Alter
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: