Uploaded image for project: 'Titanium SDK/CLI'
  1. Titanium SDK/CLI
  2. TIMOB-26791

Windows: Ti.UI.View reports top/left/bottom/right values as Strings always

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: Release 8.0.0
    • Fix Version/s: Release 8.1.0
    • Component/s: Windows
    • Labels:
      None
    • Story Points:
      8
    • Sprint:
      2019 Sprint 5, 2019 Sprint 7, 2019 Sprint 8

      Description

      I'm in the process of updating our test suite to use the latest should.js library, which now uses a stricter equality check. As a result, the tests are now flagging a number of windows UI tests as failing due to comparisons against expected numeric values. (the comparison used to do == but now do === so won't coerce to Number)

      Turns out we're reporting string values for top/left/right/bottom always on Windows where we report Numbers on Android/iOS. The properties themselves are Number or String, so Strings can be valid but would typically be reported when followed by the "unit" (i.e. "px", "em", "%").

      For parity's sake, I think it'd be good to report the values as Numbers when they're purely numeric/have no units explicitly attached.

        Attachments

          Activity

            People

            • Assignee:
              kiguchi Kota Iguchi
              Reporter:
              cwilliams Christopher Williams
              Reviewer:
              Gary Mathews
              Tester:
              Keerthi Mahalingam (Inactive)
            • Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Backbone Issue Sync

                • Titanium SDK/CLI <> Titanium Mobile
                  Synced with:
                  TIMOB-21009
                  Sync status:
                  PENDING
                  Last received:
                  Last sent:

                  Git Source Code