Uploaded image for project: 'Titanium SDK/CLI'
  1. Titanium SDK/CLI
  2. TIMOB-26376

Android: Remove "commons-codec.jar" and replace with Java "MessageDigest"

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Low
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Release 7.5.0
    • Component/s: Android
    • Labels:
    • Story Points:
      7

      Description

      Summary:
      The Titanium SDK currently uses the Apache "commons-codec.jar" to generate MD5 hashes for its JavaScripts APIs such as Ti.Utils.md5HexDigest() and internally via the Java DigestUtils class.

      We should remove this JAR file to reduce APK bloat and replace its usage with the built-in Java "MessageDigest" class provided by Android here...
      https://developer.android.com/reference/java/security/MessageDigest

      To simplify the transition, we can create our own Titanium TiDigestUtils Java class to ease the transition internally.

      Note:
      This was changed was suggested when Apache hashing broke when an app targets Android P. Please see the discussion in the PR below...
      https://github.com/appcelerator/titanium_mobile/pull/10253

        Attachments

          Activity

            People

            • Assignee:
              jquick Joshua Quick
              Reporter:
              jquick Joshua Quick
              Reviewer:
              Gary Mathews
            • Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Backbone Issue Sync

                • Backbone Issue Sync is enabled for your project, but we do not have any synchronization info for this issue.

                  Git Source Code