Uploaded image for project: 'Titanium SDK/CLI'
  1. Titanium SDK/CLI
  2. TIMOB-25600

Android : SDK 7.0.0.GA not applying custom theme attributes properly on TableViewRow, but SDK 5.5.1 or below works properly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Release 7.1.0
    • Component/s: Android
    • Labels:
      None
    • Environment:

      Tested on below environments:

      • Titanium SDK 7.0.0.GA & 5.5.1.GA
      • Android OS 7.1.1 (Nokia 5 & Nexus 9)
      • Android OS 6.0.1 (Moto G4 Play & Samsung On5)
    • Sprint:
      2018 Sprint 05 SDK, 2018 Sprint 04 SDK

      Description

      When using custom theme to change the touch-ripple colour on tableview rows, touch-ripple colour is not applied using SDK 7.0.0.GA, however it works as expected while using 5.5.1.GA or below.

      It makes impossible to change the ripple-effect colour using 7.0.0.GA & even it's behaving odd if I use touchFeedbackColor on tableview rows.

      Here's a sample code to test this:

      var win = Ti.UI.createWindow({
      	backgroundColor : 'black',
      	theme : 'GalleryTheme'
      });
       
      var table = Ti.UI.createTableView({
      	width : Ti.UI.FILL,
      	height : Ti.UI.FILL
      });
       
      table.appendRow(createRow("Camera Test"));
      table.appendRow(createRow("Multi Image Picker"));
      table.appendRow(createRow("Image Compression Test"));
      table.appendRow(createRow("Get Current Location"));
       
      win.add(table);
       
      win.open();
       
      function createRow(_text) {
      	var label = Ti.UI.createLabel({
      		color: 'white',
      		text: _text,
      		left : 20,
      		width: Ti.UI.SIZE, height: Ti.UI.SIZE
      	});
       
      	var row = Ti.UI.createTableViewRow({
      		height: 50,
      	        width: Ti.UI.FILL
      	});
       
      	row.add(label);
      	return row;
      }
       
      // theme used in this sample to change ripple effect
      <style name="GalleryTheme" parent="Theme.AppCompat.Light">
              <item name="colorPrimary">#ffbc77</item>
              <item name="colorPrimaryDark">#cf9458</item>
              <item name="colorAccent">#4064ff</item>
      	<item name="colorControlHighlight">#2eba4d</item>
      </style>
      

      As expected, `colorControlHighlight` colour should be used to show ripple-colour effect.

      Also find attached screenshot for both SDKs.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ybanev Yordan Banev
                Reporter:
                prashant_saini Prashant Saini
                Reviewer:
                Gary Mathews
                Tester:
                Lokesh Choudhary
              • Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Backbone Issue Sync

                  • It looks like Backbone Issue Sync is not enabled for your project.

                    Git Source Code