Uploaded image for project: 'Titanium SDK/CLI'
  1. Titanium SDK/CLI
  2. TIMOB-24693

LiveView: Incorrect argument checked for custom IP

    Details

    • Type: Bug
    • Status: Closed
    • Priority: None
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Release 6.1.0
    • Component/s: LiveView
    • Labels:
      None
    • Environment:

      LiveView: 1.1.12
      Appcelerator Studio: 4.9.0.201705121309

      Description

      Description

      When passing in a custom IP for liveview to use the command line arg is --liveview-ip, liveview checks for liveview-host https://github.com/appcelerator/liveview/blob/4de3f39330fcd6de5ca90b406f4b94c4feaf32d1/hook/lvhook.js#L129

      Steps to reproduce
      1. Build an app with --liveview --liveview-ip 123.4.5.6
      2. Check the logs
      Actual

      App starts and errors out that it cant access an ip that is not 123.4.5.6

      Expected

      App should start and error out that it cant access 123.4.5.6

        Attachments

          Activity

            People

            • Assignee:
              eharris Ewan Harris
              Reporter:
              eharris Ewan Harris
              Reviewer:
              Feon Sua Xin Miao
              Tester:
              Abir Mukherjee
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Backbone Issue Sync

                • Titanium SDK/CLI <> Titanium Mobile
                  Synced with:
                  TIMOB-10687
                  Sync status:
                  ERROR
                  Last received:
                  Last sent:

                  Git Source Code