Uploaded image for project: 'Titanium SDK/CLI'
  1. Titanium SDK/CLI
  2. TIMOB-23575

Windows: CLI does not check correct directories when detecting app icons

    Details

    • Type: Bug
    • Status: Closed
    • Priority: None
    • Resolution: Fixed
    • Affects Version/s: Release 5.4.0, Release 5.3.0
    • Fix Version/s: Release 6.0.0
    • Component/s: Windows
    • Labels:
    • Environment:

      Windows 10 Pro
      Ti SDK: 5.4.0.v20160629063537
      Appc NPM: 4.2.7-2
      Appc CLI: 5.4.0-23
      Appc Studio: 4.7.0.201606220541

    • Story Points:
      5
    • Sprint:
      2016 Sprint 14 SDK

      Description

      Description

      When building for Windows Platform currently the following is performed when generating app icons, as seen in the code

      1. Check for icon in <project_dir>\app\assets\windows
      2. Check for icon in <project_dir>\
      3. Check for presence of <project_dir>\DefaultIcon-windows.png and generate using this if it exists
      4. Check for presence of <project_dir>\DefaultIcon.png and generate using this if it exists

      To be in parity with other platforms the locations should be changed to the following in this order:

      1. Check for icon in <project_dir>\Resources\windows\
      2. Check for icon in <project_dir>\Resources\
      3. Check for <project_dir>\DefaultIcon-windows.png and generate using this if it exists
      4. Check for <project_dir>\DefaultIcon.png and generate using this if it exists
      Steps to reproduce
      1. Build a classic Titanium project for the Windows Platform using appc run -p windows -T wp-device --build-only
      2. Copy the icons from <project_dir>\build\windows\Assets to <project_dir>\Resources\windows
      3. Build the project using appc run -p windows -T wp-device --build-only
      4. Copy the icons from <project_dir>\build\windows\Assets to <project_dir>\Resources
      5. Build the project using appc run -p windows -T wp-device --build-only
      Actual result

      In both step 3 and 5, app icons will be generated

      Expected result

      In both step 3 and 5, app icons should not be generated as they are located in the correct locations

        Attachments

          Activity

            People

            • Assignee:
              gmathews Gary Mathews
              Reporter:
              eharris Ewan Harris
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Backbone Issue Sync

                • Titanium SDK/CLI <> Titanium Mobile
                  Synced with:
                  TIMOB-9866
                  Sync status:
                  ERROR
                  Last received:
                  Last sent:

                  Git Source Code