Uploaded image for project: 'Titanium SDK/CLI'
  1. Titanium SDK/CLI
  2. TIMOB-20451

Window.close should use new activity*Transition instead of activity*Animation or default

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: Release 5.2.0
    • Fix Version/s: Release 5.4.0
    • Component/s: Android
    • Labels:
      None
    • Environment:

      SDK 5.2.0.GA

    • Story Points:
      3
    • Sprint:
      2016 Sprint 09 SDK

      Description

      With TIMOB-19580 we have introduced activity*Transition properties for Ti.UI.Window.

      We also still have activity*Animation properties for Ti.UI.Window.open() and Ti.UI.Window.close().

      The Issue

      This is confusing, but also seems to not always work as expected:

      If you try the Activity Transitions example in the Ti 5.2.0 Sample App and set all activity*Transition properties to TRANSITION_NONE you will see that if you use the system navigation bar (or hardware) back button in Window B it will indeed close without animation. But if you use the Action Bar Level Up icon (which simply calls Ti.UI.Window.close()) it will fade out.

      Solution

      We should:

      1. Make sure that if I call Ti.UI.Window.close() without activityEnterAnimation and activityExitAnimation, it will honour Ti.UI.Window.activityReturnTransition.

      2. Deprecate and in 6.0 remove the activity*Animation properties.

      Source

      Related code:

      https://github.com/appcelerator/titanium_mobile/blob/a67afc862cd344bf1293b16142317aad0b5ee122/android/modules/ui/src/java/ti/modules/titanium/ui/WindowProxy.java#L135-L184

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ssombhatla Srikanth Sombhatla (Inactive)
                Reporter:
                fokkezb Fokke Zandbergen
                Reviewer:
                Ashraf Abu (Inactive)
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Backbone Issue Sync

                  • Titanium SDK/CLI <> Titanium Mobile
                    Synced with:
                    TIMOB-20997
                    Sync status:
                    ERROR
                    Last received:
                    Last sent:

                    Git Source Code