Uploaded image for project: 'Titanium SDK/CLI'
  1. Titanium SDK/CLI
  2. TIMOB-16229

Don't check license for free modules on the marketplace

    Details

      Description

      I've been getting lots of positive reactions to the launch of the gitTio search engine and CLI package manager.

      However, some people ran into problems after manually downloading and installing a distribution of a module available on GitHub, or using the CLI to do this for them.

      This problem occurs when these modules are also listed on the Appcelerator Marketplace. When you download such a module straight from GitHub (or somewhere else), you will not be able to run an app using the module, because it will check with Marketplace if you have required the license.

      Steps to reproduce

      1. Create a new project: ti create -p ios -n license --id test.license -d .
      2. Do NOT purchase the free ZIP / UnZIP module from the Marketplace
      3. Download the distribution straight from GitHub and add the dependency (<module platform="iphone" version="1.1">de.marcelpociot.zip</module>) to tiapp.xml or simply use the gitTio CLI: gittio install -g de.marcelpociot.zip in the project.
      4. Build the project: ti build - ios
      5. Meet the beautiful red screen attached.

      Solution

      Of course this license verification is great for paid modules, but for free modules this makes no sense. I can imagine people like the stats they get about the usage of their modules, but this could still be tracked, while not raising the red screen at the same time.

      I really urge you guys to consider this small modification. If the module is listed as Free on the marketplace, just track its usage, but don't trigger the red screen.

        Activity

        Hide
        andrew@gstreetmedia.com Andrew Greenstreet added a comment -

        Can you change the licensing message to reflect the module that is actually throwing the error? Sometimes the only way I can get my project to work, is remove all the modules, and add them back one by one, compiling and testing each time. Is this happening to users of my app? I have no idea, why this keeps popping up for me or how to fix it because I have no idea what module is the problem. Frankly, I'm not even sure a specific module is the issue, rather just the use of modules period.

        Show
        andrew@gstreetmedia.com Andrew Greenstreet added a comment - Can you change the licensing message to reflect the module that is actually throwing the error? Sometimes the only way I can get my project to work, is remove all the modules, and add them back one by one, compiling and testing each time. Is this happening to users of my app? I have no idea, why this keeps popping up for me or how to fix it because I have no idea what module is the problem. Frankly, I'm not even sure a specific module is the issue, rather just the use of modules period.
        Hide
        cbarber Chris Barber added a comment - - edited

        Andrew Greenstreet I added this to the backend about 4 months ago and it just landed in production, unfortunately Titanium does not yet report these issues. I've created TIMOB-17834 and TIMOB-17835 to report modules that failed verification.

        In the meantime, you will need to comment out modules to figure out which ones are not passing verification.

        Show
        cbarber Chris Barber added a comment - - edited Andrew Greenstreet I added this to the backend about 4 months ago and it just landed in production, unfortunately Titanium does not yet report these issues. I've created TIMOB-17834 and TIMOB-17835 to report modules that failed verification. In the meantime, you will need to comment out modules to figure out which ones are not passing verification.
        Hide
        fokkezb Fokke Zandbergen added a comment -

        Chris Barber, so this ticket is resolved now? That would be great!

        Show
        fokkezb Fokke Zandbergen added a comment - Chris Barber , so this ticket is resolved now? That would be great!
        Hide
        cbarber Chris Barber added a comment -

        Fokke Well, for brand new, never been downloaded by anyone, modules, yeah, it should be working. But for any existing free modules, we would need to manually flip a switch. :/

        Show
        cbarber Chris Barber added a comment - Fokke Well, for brand new, never been downloaded by anyone, modules, yeah, it should be working. But for any existing free modules, we would need to manually flip a switch. :/
        Hide
        fokkezb Fokke Zandbergen added a comment -

        Curious about how you implemented it if it only works for new modules, but flipping the switch on existig should be as simple as a SQL REPLACE right?

        Show
        fokkezb Fokke Zandbergen added a comment - Curious about how you implemented it if it only works for new modules, but flipping the switch on existig should be as simple as a SQL REPLACE right?

          People

          • Assignee:
            emerriman Eric Merriman
            Reporter:
            fokkezb Fokke Zandbergen
          • Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:

              Development

                Poker Sessions

                This issue is currently not assigned to any Poker Session.

                  Git Source Code