Titanium Mobile
  1. Titanium Mobile
  2. TIMOB-11580

Android: VideoPlayer.playbackstate.playbackstate should be playbackState

    Details

      Description

      The playbackstate event has a property named playbackState. However, on Android, when the event was renamed from playbackState to playbackstate, the event property was renamed as well.

      The property name should stay the same, as it is documented, as it worked on Android in 2.1.3, and as it works in iOS in 3.0.

        Activity

        Hide
        Arthur Evans added a comment -

        This is a regression as well, since the property was renamed in both the legacy playbackState and the new playbackstate events.

        Show
        Arthur Evans added a comment - This is a regression as well, since the property was renamed in both the legacy playbackState and the new playbackstate events.
        Hide
        Ping Wang added a comment -

        PR https://github.com/appcelerator/titanium_mobile/pull/3346
        For FR, please run KS->Phone->Play Movie->Local and check the log in the console. Should see something like:

        I/TiAPI   ( 3788):  Event PlaybackState Fired: 1
        

        Without the fix, the log is:

        I/TiAPI   ( 4401):  Event PlaybackState Fired: undefined
        
        Show
        Ping Wang added a comment - PR https://github.com/appcelerator/titanium_mobile/pull/3346 For FR, please run KS->Phone->Play Movie->Local and check the log in the console. Should see something like: I/TiAPI ( 3788): Event PlaybackState Fired: 1 Without the fix, the log is: I/TiAPI ( 4401): Event PlaybackState Fired: undefined
        Show
        Ping Wang added a comment - 3_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/3347
        Hide
        Natalie Huynh added a comment -

        Tested with 3.0.0.v201211300200208 with Galaxy s3 4.0.4 and iphone 4 5.1.1

        Show
        Natalie Huynh added a comment - Tested with 3.0.0.v201211300200208 with Galaxy s3 4.0.4 and iphone 4 5.1.1

          People

          • Assignee:
            Ping Wang
            Reporter:
            Arthur Evans
          • Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: