Uploaded image for project: 'Appcelerator CLI'
  1. Appcelerator CLI
  2. CLI-955

CLI should not tell a user to install a pre-release CLI as an update from a GA version

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: Release 5.2.0
    • Fix Version/s: Release 5.3.0, Release 5.4.0
    • Component/s: Core
    • Labels:
    • Environment:

      Windows 10, Mac 10.11.3
      Appc CLI NPM: 4.2.3
      Appc CLI core: 5.2.0

    • Severity:
      Major
    • Story Points:
      3
    • Sprint:
      2016 Sprint 09 Tooling

      Description

      Description

      When telling a user that there is a new CLI we currently will tell them to update to a pre-release version. We should only tell a user to update if the version is not pre-release. See the below.

      A new update (5.2.0-265) is available... Download with appc use 5.2.0-265
      Appcelerator Command-Line Interface, version 5.2.0
      

      In the updateCheck method we appear to be calling the api/appc/list endpoint, we should either filter the pre-release CLIs from this using the prerelease parameter or we should use the api/appc/latest endpoint.

      This also shows that the logic used is incorrect or does not compare the actual version numbers as 5.2.0-265 should not be considered an update to 5.2.0

      Steps to reproduce

      1. Remove the lastUpdateCheck property from your appc-cli.json file
      2. Run an appc command such as appc config

      Actual result

      1. The following will be printed out, prompting the user to update to a pre-release version

      A new update (5.2.0-265) is available... Download with appc use 5.2.0-265
      Appcelerator Command-Line Interface, version 5.2.0
      

      Expected result

      1. We should only prompt a user to update to if the version is not pre-release

        Attachments

          Activity

            People

            • Assignee:
              fmiao Feon Sua Xin Miao
              Reporter:
              eharris Ewan Harris
              Reviewer:
              Chee Kiat Ng (Inactive)
            • Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Git Source Code