Aptana Studio
  1. Aptana Studio
  2. APSTUD-4627

JavaScript: Outline view does not descend into functions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: None None
    • Resolution: Fixed
    • Affects Version/s: Aptana Studio 3.0.9
    • Component/s: indexing, js-libraries
    • Labels:
      None
    • Environment:

      Ubuntu 11.10, AMD64, Eclipse indo build M20110909-1335

    • Story Points:
      8

      Description

      The Javascript Outline view in Studio 3 almost displaying nothing of my code while the same outline in Eclipse WTP displays a lot more. Here the problem seems to be that the code is hidden inside a function. See the attachments. I expect the methods to be displayed but they are not.

      1. Test.js
        1.0 kB
        Pierre Thibault
      1. Outline-Studio3.png
        7 kB
      2. Outline-WTP.png
        24 kB
      3. Screen Shot 2012-04-27 at 9.38.51 AM.png
        69 kB
      4. Screen Shot 2012-05-22 at May 22,3.10.42 PM.png
        26 kB
      5. Screen Shot 2012-05-23 at 9.43.25 AM.png
        35 kB

        Issue Links

          Activity

          Hide
          Ingo Muschenetz added a comment - - edited

          There's a bug now--notice the infinite recursion. The end goal should be (independent of the recursion issue) is to combine the <function> and the MyObject nodes as a "function" node named "MyObject".

          Show
          Ingo Muschenetz added a comment - - edited There's a bug now--notice the infinite recursion. The end goal should be (independent of the recursion issue) is to combine the <function> and the MyObject nodes as a "function" node named "MyObject".
          Hide
          Michael Xia (Inactive) added a comment -

          The cause for the infinite recursion is due to the variable being the same as the function name inside (both are myObject). Once the variable name is changed to say "foo", the problem will go away. Will implement a fix for when the names are the same.

          Show
          Michael Xia (Inactive) added a comment - The cause for the infinite recursion is due to the variable being the same as the function name inside (both are myObject). Once the variable name is changed to say "foo", the problem will go away. Will implement a fix for when the names are the same.
          Hide
          Michael Xia (Inactive) added a comment -

          Fixed by checking against the type of JS outline item in question (function vs. variable). I'll leave the anonymous function node in since I believe it is still useful to distinguish it from a regular function declaration, and we also have a ticket in APSTUD-4605 that addresses a related concern.

          Show
          Michael Xia (Inactive) added a comment - Fixed by checking against the type of JS outline item in question (function vs. variable). I'll leave the anonymous function node in since I believe it is still useful to distinguish it from a regular function declaration, and we also have a ticket in APSTUD-4605 that addresses a related concern.
          Hide
          Michael Xia (Inactive) added a comment -

          Hi Clayton,

          The fix didn't get into last night's nightly build due to a build failure from another commit. Tonight's build should include the fix.

          Show
          Michael Xia (Inactive) added a comment - Hi Clayton, The fix didn't get into last night's nightly build due to a build failure from another commit. Tonight's build should include the fix.
          Hide
          Michael Xia (Inactive) added a comment -

          Also the fix is applied to development branch for 2.1.0 only.

          Show
          Michael Xia (Inactive) added a comment - Also the fix is applied to development branch for 2.1.0 only.
          Hide
          Chris Williams added a comment -

          Verified against Aptana Studio 3, build: 3.2.0.201205231357
          Build: jenkins-studio3-rcp-development-817 (origin/development)
          Date: 23 May 2012, 13:58:15

          Show
          Chris Williams added a comment - Verified against Aptana Studio 3, build: 3.2.0.201205231357 Build: jenkins-studio3-rcp-development-817 (origin/development) Date: 23 May 2012, 13:58:15

            People

            • Assignee:
              Michael Xia (Inactive)
              Reporter:
              Pierre Thibault
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: