Aptana Studio
  1. Aptana Studio
  2. APSTUD-3646

CharacterPairMatcher performance issues

    Details

      Description

      The CharacterPairMatcher is showing as a hotspot during profiling, and it runs in the single UI thread, so it is particularly important to improve. Suggest replacing the DocumentPartitionAccessor impl, since it looks like it looks up the partition/scope/matches against a scope selector for every single character we try. We should be able to grab the partitions between position and end of file/start of file (based on forwards/backwards search), and then skip partitions en masse, and search each partition.

        Activity

        Hide
        Chris Williams added a comment -

        Pushed fix to both release and development branches.

        Show
        Chris Williams added a comment - Pushed fix to both release and development branches.
        Hide
        Ingo Muschenetz added a comment -

        I would confirm that typing { } characters and highlighting matching characters is faster (or at least no slower) in a new version.

        Show
        Ingo Muschenetz added a comment - I would confirm that typing { } characters and highlighting matching characters is faster (or at least no slower) in a new version.
        Hide
        Joel Witt (Inactive) added a comment -

        Aptana Studio 3, build: 3.0.7.201112021709
        Virtual Machine with Windows XP

        Entering matching characters was not an issue on the previous version (please see capture at http://www.screencast.com/t/WSaTZtnW6), however I confirmed marking occurrences of matching characters is faster with the current version (please see capture at http://www.screencast.com/t/AkZM3kDPS).

        Show
        Joel Witt (Inactive) added a comment - Aptana Studio 3, build: 3.0.7.201112021709 Virtual Machine with Windows XP Entering matching characters was not an issue on the previous version (please see capture at http://www.screencast.com/t/WSaTZtnW6 ), however I confirmed marking occurrences of matching characters is faster with the current version (please see capture at http://www.screencast.com/t/AkZM3kDPS ).

          People

          • Assignee:
            Chris Williams
            Reporter:
            Chris Williams
          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development