Uploaded image for project: 'Alloy'
  1. Alloy
  2. ALOY-1620

Fix new Buffer deprecation warnings

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: Alloy 1.13.0
    • Fix Version/s: CLI Release 7.0.8
    • Component/s: Tooling
    • Labels:
      None
    • Environment:

      Ti SDK: 7.1.1.GA, 7.2.0.v20180528150435, 7.3.0.v20180530072516
      Node 10.3.0

    • Story Points:
      1
    • Sprint:
      2018 Sprint 19 Tooling

      Description

      Description

      Node 10 produces a deprecation warning when the new Buffer constructor is used. See https://nodesource.com/blog/understanding-the-buffer-deprecation-in-node-js-10/ if you're curious

      In most cases I believe the most appropriate swap for us to do is turn new Buffer into Buffer.from

      There is one instance in the alloy code https://github.com/appcelerator/alloy/search?q=%22new+Buffer%22&unscoped_q=%22new+Buffer%22, it might not show up when alloy is ran however as code under node_modules will not throw the buffer deprecation warning

      We might also wish to update eslint-config-axway to include the no-buffer-constructor rule

      Steps to reproduce to be added as replacement happens

        Attachments

          Activity

            People

            • Assignee:
              eharris Ewan Harris
              Reporter:
              eharris Ewan Harris
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Backbone Issue Sync

                • Backbone Issue Sync is enabled for your project, but we do not have any synchronization info for this issue.

                  Git Source Code